Trivial patch to Brackup::Restore
gavin at openfusion.com.au
Sat Jun 28 01:42:10 UTC 2008
On Fri, Jun 27, 2008 at 06:27:02PM +0100, Martin Atkins wrote:
> Gavin Carr wrote:
>> On Tue, Jun 24, 2008 at 10:32:13PM +1000, Gavin Carr wrote:
>> Hmmm, and while in trivial patch mode, the "Restore complete." warn
>> in brackup-restore is missing a trailing "\n", unlike those in
>> Brackup::Restore - patch attached.
> I think if anything it's the other warn calls that are wrong; warn
> generally comes with its own newline as well as a reference to what line of
> code generated the warning.
> Brackup could perhaps be doing something strange that necessitates these
> unusual newlines, but I'm not sure what that would be.
It's not that unusual - adding a newline explicitly just causes the
standard code line pointer to be omitted (with die as well). These
cases looked intentional to me, as they're really just verbose
No biggie, just looks cleaner in verbose mode.
More information about the brackup