brackup possible memory leak - consumes 1.5GB+ with 64MB chunk size

[William J. Coldwell]

I wonder if this is during building of the list of files.  Since I'm
backing up 256k+ files, if this isn't stored in some sort of disk
backed array, it could suck all of the memory allowed.

--
William J. Coldwell "Cryo" WC25-ARIN
Warped, Inc.    http://warped.com
Sr. Custodial Engineer 20BOVINE29
+33° 58' 16.20", -83° 55' 50.04"


On Jul 29, 2009, at 7:55 AM, George Hills wrote:

> Hi,
>
> Thank you for the reply and patch.
>
> Gavin Carr wrote:
>
>> Could you try the attached patch and see if it helps? It makes  
>> brackup
>> write out the metafile incrementally rather than keeping it all in  
>> RAM
>> and then writing it out at the end.
>>
>> Of course, you might be hitting something earlier than this, but this
>> did seem to stabilise RAM usage for me when I wrote it.
>>
>> It should be stable (if I've pulled it out correctly) as I've been
>> running it myself for quite a while.
>
> The patch applies cleanly and brackup seems to work exactly as  
> before -
> that is to say it fairly rapdily consumes all the available RAM
> (1500MB+) and dies.
>
> Cheers.
>
> -- 
> George Hills
> Systems Administrator
> Brightbox
> http://www.brightbox.co.uk/