Build and test fixes

Gavin Carr gavin at openfusion.com.au
Wed Apr 28 18:47:37 UTC 2010


On Fri, Apr 09, 2010 at 04:59:18PM -0400, Alex Vandiver wrote:
>   Attached are two minor fixes to the build process (ignoring .git
> directories, and adding Test::More and ExtUtils::Manifest minimum
> versions), 

These are committed - thanks!

> as well as a tweak to gpg tests.  Specifically, if a user
> doesn't have a ~/.gnupg when the tests are run, t/02-gpg.t produces:
> 
<snip>
> 
> ...and things go generally downhill from there.  Thus, the third patch
> sets the GNUPGHOME environment variable to a temporary directory before
> starting the tests, ensuring that we avoid this problem, as well as not
> having to worry about the user's local gnupg settings.  The downside is
> that it outputs:
>         gpg: /tmp/CB5HdrFYX6/L3yUx1zYHz/trustdb.gpg: trustdb created
> ...to STDERR on every GPG test, however, and I've not been able to find
> a way to prevent gpg from doing so, short of 2>/dev/null, which would be
> wrong.  Thoughts appreciated.

It does make the output a bit noisier, which is a bit annoying, but not
terrible. What do you think about only setting GNUPGHOME if no ~/.gnupg 
exists? Could user settings screw up the tests?

Cheers,
Gavin



More information about the brackup mailing list