We haven't seen a patch yet to object to. :-)<br><br><div class="gmail_quote">On Thu, Nov 13, 2008 at 9:54 PM, Gavin Carr <span dir="ltr"><<a href="mailto:gavin@openfusion.com.au">gavin@openfusion.com.au</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I've had one positive comment (offlist?). Barring objections I'm<br>
likely to go ahead and add this in. We can tweak/change/rip out<br>
later if required, I guess.<br>
<br>
Please speak up if you have opinion/thoughts.<br>
<br>
Cheers,<br>
<font color="#888888">Gavin<br>
</font><div><div></div><div class="Wj3C7c"><br>
<br>
On Fri, Nov 07, 2008 at 09:12:15PM +1100, Gavin Carr wrote:<br>
> Brackup trunk has a stats placeholder as a todo list item. I've<br>
> gone ahead and implemented some stats for my use that look like<br>
> this:<br>
><br>
> BACKUPS STATS:<br>
><br>
> Start Time: Fri Nov 7 00:15:03 2008<br>
> End Time: Fri Nov 7 00:58:02 2008<br>
> File Discovery Time: 240s<br>
> Chunk Iterator Time: 0s<br>
> Chunk Storage Time: 2327s<br>
> Metafile Storage Time: 12s<br>
> Total Run Time: 2579s<br>
><br>
> Post File Discovery Memory Usage: 352.7 MB<br>
> Post Chunk Iterator Memory Usage: 363.8 MB<br>
> Post Chunk Storage Memory Usage: 1354.0 MB<br>
> Post Metafile Storage Memory Usage: 1549.1 MB<br>
> Peak Memory Usage: 1549.1 MB<br>
><br>
> Number of Files 297048<br>
> Total File Size 1302044.0 MB<br>
> Number of Files Uploaded: 535<br>
> Total File Size Uploaded: 31654.1 MB<br>
> Run Arguments: --from=exportp --to=mercury_ftp_exportp --save-stats --gtop-stats<br>
><br>
> That basically covers some timing stats, some memory usage measurements<br>
> (via gtop), and some file and size counts. I've added a --save-stats<br>
> option which records the output to a .stats file with the same name and<br>
> location as the .brackup file produced.<br>
><br>
> So some questions:<br>
><br>
> - are people interested in this as a first pass at some stats?<br>
><br>
> - what have I missed that people would like to see included (and Brad,<br>
> what were you envisaging including here?)<br>
><br>
> - any general suggestions / comments / critiques on this?<br>
><br>
> Cheers,<br>
> Gavin<br>
><br>
</div></div></blockquote></div><br>