Committed & 1.09 released to CPAN.<div><br></div><div>It would've been nice to have a new test, though, that showed encrypted metafiles decrypting properly.</div><div><br><div class="gmail_quote">On Sun, May 17, 2009 at 11:00 PM, Chris Anderson <span dir="ltr"><<a href="mailto:cva@pobox.com">cva@pobox.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">ping.<div><div></div><div class="h5"><br><br><div class="gmail_quote">On Mon, May 4, 2009 at 11:13 PM, Chris Anderson <span dir="ltr"><<a href="mailto:cva@pobox.com" target="_blank">cva@pobox.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I fixed the MANIFEST and the test failure. I also rewrote Decrypt::decrypt_data from Stephane's original patch which was creating unnecessary temp files when the data wasn't encrypted in the first place.<div><br>
</div>
<div>I have tested restore and gc using both encrypted and unencrypted S3 backups.</div><div><br></div><div>cva<div><div></div><div><br><br><div class="gmail_quote">On Sat, May 2, 2009 at 8:36 PM, Brad Fitzpatrick <span dir="ltr"><<a href="mailto:brad@danga.com" target="_blank">brad@danga.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Patch doesn't look that bad, but it doesn't even pass "make test" for me. And it's missing the two new files from its MANIFEST.<br>
<br>Fix the tests and I'll look again:<br><br># Failed test 'did the restore'<br>
# at /home/bradfitz/proj/brackup/blib/lib/Brackup/Test.pm line 106.<br>restore failed: Can't locate object method "decrypt_data" via package "Brackup::Restore" at /raid/bradfitz/proj/brackup/blib/lib/Brackup/Restore.pm line 205.<div>
<div></div><div><br>
<br><div class="gmail_quote">On Tue, Apr 28, 2009 at 7:39 PM, Chris Anderson <span dir="ltr"><<a href="mailto:cva@pobox.com" target="_blank">cva@pobox.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">
done<div><br></div><div><a href="http://codereview.appspot.com/52065/show" target="_blank">http://codereview.appspot.com/52065/show</a><br><br><div class="gmail_quote">this is stephane's patch with one typo corrected (and I commented out a line which required you to hit enter after each metafile was decrypted).</div>
<div class="gmail_quote"><br></div><div class="gmail_quote">cva</div><div><div></div><div><div class="gmail_quote"><br></div><div class="gmail_quote">On Fri, Apr 24, 2009 at 3:04 PM, Brad Fitzpatrick <span dir="ltr"><<a href="mailto:brad@danga.com" target="_blank">brad@danga.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">Where's the patch? Could somebody upload it to <a href="http://codereview.appspot.com" target="_blank">codereview.appspot.com</a>? I find it easiest to suck things down from there (it has raw download patch URLs), even if there are no comments on the code itself.<div>
<div></div><div><div>
<br><div class="gmail_quote">On Fri, Apr 24, 2009 at 11:52 AM, Chris Anderson <span dir="ltr"><<a href="mailto:cva@pobox.com" target="_blank">cva@pobox.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">
I applied this patch last night and after making a couple small changes it seems to work just fine (though I haven't tested all of the edge cases).<br><br>Can we get this committed? <br><br>cva<div><div></div><div>
<br><br><div class="gmail_quote">
On Mon, Apr 20, 2009 at 2:01 AM, Stéphane Alnet <span dir="ltr"><<a href="mailto:stephane@shimaore.net" target="_blank">stephane@shimaore.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">
Chris,<br>
<div><br>
> I'm waking up this thread to see if there was ever a consensus as to whether<br>
> this was the preferred solution or people preferred the patch for doing gc<br>
> against local metafiles.<br>
<br>
</div>The patch was designed to allow both, but I didn't want to mess up<br>
gc() so I didn't add an option for local metafiles.<br>
<br>
Essentially the two lines in Brackup::Target that read:<br>
<br>
my $decrypted_backup = new Brackup::DecryptedFile($tempfile);<br>
my $parser = Brackup::Metafile->open($decrypted_backup->name);<br>
<br>
would need to be rewritten:<br>
<br>
my $parser;<br>
if($use_local_metafile)<br>
{<br>
# Assumes local metafiles are unencrypted.<br>
$parser = Brackup::Metafile->open($local_metafile_name);<br>
}<br>
else<br>
{<br>
$self->get_backup($backup->filename, $tempfile);<br>
$decrypted_backup = new Brackup::DecryptedFile($tempfile);<br>
$parser = Brackup::Metafile->open($decrypted_backup->name);<br>
}<br>
<br>
But the outside loop in gc() needs to be rewritten, in order to<br>
account for local metafiles and provide $use_local_metafile flag and<br>
the $local_metafile_name above.<br>
<div><br>
> Either way, does anyone have a version of this<br>
> patch which will apply cleanly to 1.07 and, if so, is there any interest in<br>
> getting this committed?<br>
<br>
</div>I just tested and it seems to apply cleanly to 1.07.<br>
<font color="#888888">Stéphane<br>
</font></blockquote></div><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br>
</div></div></blockquote></div><br></div>