code quality cleanups

[Paul Lindner]

On Fri, Mar 16, 2007 at 06:28:15PM +0000, Brad Fitzpatrick wrote:
> Well, don't do cleanups and bug fixes in same commit, for sure.  Bug fixes
> should be discussed first, unless they're _incredibly_ obvious.

Yes, that's basically what I was trying to say..  :)

Just to double check I'll pass on the cleanups patch first so everyone
can see it prior to committing it.

> On Fri, 16 Mar 2007, Paul Lindner wrote:
> 
> > On Fri, Mar 16, 2007 at 05:42:52PM +0000, Brad Fitzpatrick wrote:
> > > Just don't go too crazy, please.
> >
> > I've been using these changes internally for some time now, plus all
> > the tests pass -- shouldn't cause a problem.
> >
> > By doing this cleanup I believe I've uncovered some potential bugs
> > too, more on that later today...
> >
> >
> > > On Fri, 16 Mar 2007, Paul Lindner wrote:
> > >
> > > > I'm actively working on extending DJabberd and have cleaned up the
> > > > base code by running it through perlcritic at various levels.
> > > >
> > > > I'll commit these changes starting today.
> > > >
> > > > Most of the changes are relatively simple.  Turning on warnings, using
> > > > 3-arg open, Time::Hires instead of 4 arg select, etc.
> > > >
> > > >
> >
> >

-- 
Paul Lindner        ||||| | | | |  |  |  |   |   |
lindner at inuus.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.danga.com/pipermail/djabberd/attachments/20070316/5b4e45e4/attachment.pgp