annoying logging here

[Brad Fitzpatrick]

Thanks! :)

On Fri, Aug 1, 2008 at 5:58 PM, Bron Gondwana <brong at fastmail.fm> wrote:

> On Fri, Aug 01, 2008 at 09:36:52AM -0700, Brad Fitzpatrick wrote:
> > On Thu, Jul 31, 2008 at 11:14 PM, Bron Gondwana <brong at fastmail.fm>
> wrote:
> >
> > >
> > > Fixed.
> > >
> > > That is - fixed by explicitly starting the logger in BEGIN blocks
> during
> > > all the tests.
> >
> >
> > Hm, I was hoping for something a little less... repetitive.  :-)
>
> That would involve either having those remaining tests include
> t/lib/djabberd-test.pl (not necessarily a bad idea) or changing the
> logging code to be silent (possibly good, but I don't know the reasoning
> behind warning there in the first place, so I didn't want to mess with
> it!)
>
> ------------------------------------------------------------------------
> r793 | brong | 2008-08-02 10:57:38 +1000 (Sat, 02 Aug 2008) | 6 lines
>
> require t/lib/djabberd-test.pl in all DJabberd module tests
>
> This pulls all the Log->set_logger() code into the one place
> and is 'a little less... repetitive' (hi Brad)
>
> ------------------------------------------------------------------------
>
> Passes all tests again for me, with no logger noise.
>
> Bron.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.danga.com/pipermail/djabberd/attachments/20080801/bd2422ee/attachment.htm