[djabberd] kane, r799: r6897@db-dev1: josboum | 2008-08-06 19...
Martin Atkins
mart at degeneration.co.uk
Wed Aug 6 20:48:03 UTC 2008
Brad Fitzpatrick wrote:
>
> On Wed, Aug 6, 2008 at 10:44 AM, <commits at code.sixapart.com
> <mailto:commits at code.sixapart.com>> wrote:
>
>
> + { use B;
>
>
> use B at top of the file, not here. use is compile-time anyway, so this
> buys nothing. and import it as use B (); just to be clear that you're
> importing no symbols.
>
Also not a fan of code following { on the same line. It's inconsistent
with everything else.
It'd also be nice to have a comment explaining what's going on here.
Calls into B:: are not exactly intuitive.
More information about the Djabberd
mailing list