not-authorized error during dialback authentication with gmail.com

[Gordon Irlam]

Hi,

I've been having difficulties getting my DJabberd to federate with
gmail.com.  It federates fine with jabber.com.

I've attached a packet trace at the end of this email, but it seems
the problem is caused by the following code in
Connection/ServerOut.pm:

    if ($ss->version->supports_features) {
        # they can eat a dick for all we care.  they get no features.
        # what is this weird XMPP 1.0 + old-school Dialback world anyway?
        # maybe we're still confused.  FIXME: care.
        my $features = "<stream:features></stream:features>";
        $self->write($features);
        $self->log->debug("$self->{id} sending '$features'");
    }

Deleting this code allows my DJabberd to federate with Google.

This is my first tweak to DJabberd, so I wanted to check if it is safe
to delete this code, or are there gremlins I don't understand.

Also, is this really a Google problem?  Should I follow up with them
too?

thanks,
Gordon

-----------------------------------------------------

myserver.32838 > wf-in-f125.google.com.xmpp-server:
<?xml version="1.0" encoding="UTF-8"?><stream:stream to='gmail.com'
xmlns:stream='http://etherx.jabber.org/streams' xmlns='jabber:server'
xml:lang='en' xmlns:db='jabber:server:dialback' version='1.0'>

wf-in-f125.google.com.xmpp-server > myserver.32838:
<?xml version="1.0" encoding="UTF-8"?><stream:stream from="gmail.com"
id="0A8E5AD27E429B7E" version="1.0"
xmlns:stream="http://etherx.jabber.org/streams" xmlns="jabber:server"
xmlns:db="jabber:server:dialback">

wf-in-f125.google.com.xmpp-server > myserver.32838:
<stream:features><dialback
xmlns="urn:xmpp:features:dialback"/></stream:features>

myserver.32838 > wf-in-f125.google.com.xmpp-server:
<stream:features></stream:features>

wf-in-f125.google.com.xmpp-server > myserver.32838:
<stream:error><not-authorized
xmlns="urn:ietf:params:xml:ns:xmpp-streams"/></stream:error>