On Tue, Jun 17, 2008 at 3:51 PM, Jacob Burkhart <<a href="mailto:igotimac@gmail.com">igotimac@gmail.com</a>> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hey Brad,<div><br></div><div>about the code duplication, isn't a really big part of StartTLS and OldSSLClientIn essentially duplicated code? I saw this and assumed there must be some good reason for it, so I did the same with my additions... should I try to tackle removing this duplication too?</div>
</blockquote><div><br>No, you should never be expected to clean up after more than yourself. The general rule is just to not make the situation worse. Sometimes that involves cleaning up a _bit_ more than you're responsible for, but I wouldn't expect you to go merge those two files.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>Tests appear to be passing... is there a test that specifically tests SSL?</div>
</blockquote><div><br>Not sure. There should be, but SSL tests might be hard. Please verify by hand as well to be sure.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div></div><div>Is there a faster way to run tests other than:</div><div>perl Makefile.PL && make && make test</div></blockquote><div><br>"make test" alone is usually sufficient, but yeah... that's basically it.<br>
<br>If a certain test is failing you can use "prove" or "prove -b" on it:<br><br>$ prove -b t/foo.t<br><br>Or essentially the same thing, but using lib instead of blib:<br><br>$ perl -Ilib t/foo.t<br><br>
</div></div><br>