<div dir="ltr">Thanks! :)<br><br><div class="gmail_quote">On Fri, Aug 1, 2008 at 5:58 PM, Bron Gondwana <span dir="ltr"><<a href="mailto:brong@fastmail.fm">brong@fastmail.fm</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="Wj3C7c">On Fri, Aug 01, 2008 at 09:36:52AM -0700, Brad Fitzpatrick wrote:<br>
> On Thu, Jul 31, 2008 at 11:14 PM, Bron Gondwana <<a href="mailto:brong@fastmail.fm">brong@fastmail.fm</a>> wrote:<br>
><br>
> ><br>
> > Fixed.<br>
> ><br>
> > That is - fixed by explicitly starting the logger in BEGIN blocks during<br>
> > all the tests.<br>
><br>
><br>
> Hm, I was hoping for something a little less... repetitive. :-)<br>
<br>
</div></div>That would involve either having those remaining tests include<br>
t/lib/djabberd-test.pl (not necessarily a bad idea) or changing the<br>
logging code to be silent (possibly good, but I don't know the reasoning<br>
behind warning there in the first place, so I didn't want to mess with<br>
it!)<br>
<br>
------------------------------------------------------------------------<br>
r793 | brong | 2008-08-02 10:57:38 +1000 (Sat, 02 Aug 2008) | 6 lines<br>
<br>
require t/lib/djabberd-test.pl in all DJabberd module tests<br>
<br>
This pulls all the Log->set_logger() code into the one place<br>
and is 'a little less... repetitive' (hi Brad)<br>
<br>
------------------------------------------------------------------------<br>
<br>
Passes all tests again for me, with no logger noise.<br>
<font color="#888888"><br>
Bron.<br>
</font></blockquote></div><br></div>