Let's suppose this patch is committed. Yes, it then works with Google. And then which server do we break as a result?<div><br></div><div>We need a patch which somebody has tried with many servers and if necessary auto-detects when that hack is required vs. when it's not. Or let's check it in guarded, off by default, but with a config opt/flag to enable it. Then when people report bugs in the future with the new behavior we can say "but does it work with FooOpt enabled?". And then we'll have data on a server that's required to do that for and eventually end up with a good solution.</div>
<div><br></div><div>But I'm not a fan of all these patch proposals like "well deleting this works for me" because that's not a comprehensive solution.</div><div><br></div><div>Can somebody research this more?</div>
<div><br></div><div><div><div class="gmail_quote">On Fri, Jan 30, 2009 at 11:08 PM, Piers Harding <span dir="ltr"><<a href="mailto:piers@ompka.net">piers@ompka.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi -<br>
I've reported this problem before, with openfire servers - it just<br>
started happening to me a couple of months back.<br>
<br>
I was kind of hoping someone with commit access would remove the problem<br>
code.<br>
<br>
Cheers,<br>
Piers Harding.<br>
<div><div></div><div class="Wj3C7c"><br>
<br>
<br>
<br>
On Fri, Jan 30, 2009 at 06:16:15PM -0800, Gordon Irlam wrote:<br>
> Hi,<br>
><br>
> I've been having difficulties getting my DJabberd to federate with<br>
> <a href="http://gmail.com" target="_blank">gmail.com</a>. It federates fine with <a href="http://jabber.com" target="_blank">jabber.com</a>.<br>
><br>
> I've attached a packet trace at the end of this email, but it seems<br>
> the problem is caused by the following code in<br>
> Connection/ServerOut.pm:<br>
><br>
> if ($ss->version->supports_features) {<br>
> # they can eat a dick for all we care. they get no features.<br>
> # what is this weird XMPP 1.0 + old-school Dialback world anyway?<br>
> # maybe we're still confused. FIXME: care.<br>
> my $features = "<stream:features></stream:features>";<br>
> $self->write($features);<br>
> $self->log->debug("$self->{id} sending '$features'");<br>
> }<br>
><br>
> Deleting this code allows my DJabberd to federate with Google.<br>
><br>
> This is my first tweak to DJabberd, so I wanted to check if it is safe<br>
> to delete this code, or are there gremlins I don't understand.<br>
><br>
> Also, is this really a Google problem? Should I follow up with them<br>
> too?<br>
><br>
> thanks,<br>
> Gordon<br>
><br>
> -----------------------------------------------------<br>
><br>
> myserver.32838 > wf-in-f125.google.com.xmpp-server:<br>
> <?xml version="1.0" encoding="UTF-8"?><stream:stream to='<a href="http://gmail.com" target="_blank">gmail.com</a>'<br>
> xmlns:stream='<a href="http://etherx.jabber.org/streams" target="_blank">http://etherx.jabber.org/streams</a>' xmlns='jabber:server'<br>
> xml:lang='en' xmlns:db='jabber:server:dialback' version='1.0'><br>
><br>
> wf-in-f125.google.com.xmpp-server > myserver.32838:<br>
> <?xml version="1.0" encoding="UTF-8"?><stream:stream from="<a href="http://gmail.com" target="_blank">gmail.com</a>"<br>
> id="0A8E5AD27E429B7E" version="1.0"<br>
> xmlns:stream="<a href="http://etherx.jabber.org/streams" target="_blank">http://etherx.jabber.org/streams</a>" xmlns="jabber:server"<br>
> xmlns:db="jabber:server:dialback"><br>
><br>
> wf-in-f125.google.com.xmpp-server > myserver.32838:<br>
> <stream:features><dialback<br>
> xmlns="urn:xmpp:features:dialback"/></stream:features><br>
><br>
> myserver.32838 > wf-in-f125.google.com.xmpp-server:<br>
> <stream:features></stream:features><br>
><br>
> wf-in-f125.google.com.xmpp-server > myserver.32838:<br>
> <stream:error><not-authorized<br>
> xmlns="urn:ietf:params:xml:ns:xmpp-streams"/></stream:error><br>
<br>
</div></div><font color="#888888">--<br>
Home - <a href="http://www.piersharding.com" target="_blank">http://www.piersharding.com</a><br>
<a href="mailto:xmpp%3Apiers@ompka.net">xmpp:piers@ompka.net</a><br>
<br>
</font></blockquote></div><br></div></div>