[memcached] plindner, r464: Fix slab prealloc access to uninitialize...

commits at code.sixapart.com commits at code.sixapart.com
Tue Mar 6 07:05:29 UTC 2007


Fix slab prealloc access to uninitialized data/zero-length mallocs

U   trunk/server/ChangeLog
U   trunk/server/slabs.c


Modified: trunk/server/ChangeLog
===================================================================
--- trunk/server/ChangeLog	2007-03-06 06:14:39 UTC (rev 463)
+++ trunk/server/ChangeLog	2007-03-06 07:05:28 UTC (rev 464)
@@ -1,5 +1,7 @@
 2007-03-05
-	* Paul Lindner <lindner at inuus.com>: Refactor/Cleanup
+        * Paul Lindner <lindner at inuus.com>: Fix overflow
+          bug where uninitialized access to slabclass caused
+          size-0 mallocs during slab preallocation.
 
 2006-12-23
 	* fix expirations of items set with absolute expiration times in

Modified: trunk/server/slabs.c
===================================================================
--- trunk/server/slabs.c	2007-03-06 06:14:39 UTC (rev 463)
+++ trunk/server/slabs.c	2007-03-06 07:05:28 UTC (rev 464)
@@ -119,7 +119,7 @@
     {
         char *pre_alloc = getenv("T_MEMD_SLABS_ALLOC");
         if (!pre_alloc || atoi(pre_alloc)) {
-            slabs_preallocate(limit / POWER_BLOCK);
+            slabs_preallocate(power_largest);
         }
     }
 #endif




More information about the memcached-commits mailing list