CAS is broken

dormando dormando at rydia.net
Thu Nov 15 17:13:11 UTC 2007


> 
> This test against MAX_CAS_ID is not needed: C standard _guarantees_
> that ++ for unsigned type will wraparound to zero automagically.  And
> this condition won't be ever met anyway, so the check is a bit of a
> waste (unless you have some reasons not to use full 64 bit range that
> I'm failing to see, of course).
> 
>> @@ -697,11 +698,15 @@ static void complete_nread(conn *c) {
> ...
>> +      else if(ret == 3)
>> +          out_string(c, "NOT FOUND");
> 
> Should be "NOT_FOUND" (with underscore).  This typo was present in the
> original code, and was accidentally copied here.

Both fixed in r636, plus explicitly initialized the cas_id to zero for 
portability. :)

-Dormando



More information about the memcached mailing list