Josef,<br><br>I totally agree. There are a number of strategies to implement this on the client's side. Putting this policy in the server is weird. Once it's in, then people would want to change all those magic tunables at runtime, per key, etc. Including changing the ramp-up curve of likelihood of miss between soft and hard, et.c<br>
<br>Brad<br><br><div class="gmail_quote">On Sat, Jun 14, 2008 at 10:18 AM, Josef Finsel <<a href="mailto:carpdeus@gmail.com">carpdeus@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Olivier,<br><br>Sorry, I just realized I was only responding to you, not the list as well.<br><br>My thoughts are that this is a good patch but I'm not sure it's appropriate for the server. There are many ways of handling this on the client side. The biggest concern I have with it is that it would add additional processing on every get. Not a great deal, perhaps but every little bit adds up over time, especially on larger sites.<br>
<br>If you're concern is related to cache stampedes, there are many ways to avoid them on the client. And you can even implement code to handle refreshing data before it expires so that it only affects one client instance.<br>
<br>But that's just my thoughts on this.<br><br>Josef<br clear="all"><br>"If you see a whole thing - it seems that it's always beautiful. Planets, lives... But up close a world's all dirt and rocks. And day to day, life's a hard job, you get tired, you lose the pattern."<br>
Ursula K. Le Guin
<br><div><div></div><div class="Wj3C7c"><br><div class="gmail_quote">On Sat, Jun 14, 2008 at 10:37 AM, Olivier Poitrey <<a href="mailto:rs@dailymotion.com" target="_blank">rs@dailymotion.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
If a key is very popular in the cache, when this key will expire,<br>
a lot of different clients will get an expired answer from the cache<br>
at the same time and they will gather the data from the source all<br>
at the same time. This isn't efficient, especially when the computation<br>
of the information is expensive and can takes some time.<br>
<br>
This patch adds an argument to memcached to activate soft expiration<br>
period to keys with expiration. For instance, if the soft timeout is<br>
set to 30 seconds and a key have a TTL of 50 seconds, after 20 seconds<br>
of life in the cache, memcached will start to return empty answers for<br>
this key for a small part of the queries. The more the key will be close<br>
to its real expiration time, the more important will be the propability<br>
for memcached to return an empty answer.<br>
<br>
This way, if a key is very popular, a small number of clients will<br>
see it as expired while every others will see its value as normal.<br>
This small number of clients will gather the data from the source<br>
and update the key value and chances are they will finish this<br>
before the real key expiration time.<br>
<br>
NOTE: this soft timeout is a server wide value, future version<br>
of this patch could extend the protocol in order to let clients<br>
choose this value on a per key basis.<br>
---<br>
items.c | 7 +++++++<br>
memcached.c | 14 +++++++++++++-<br>
memcached.h | 1 +<br>
3 files changed, 21 insertions(+), 1 deletions(-)<br>
<br>
diff --git a/items.c b/items.c<br>
index 88c92f6..b15325d 100644<br>
--- a/items.c<br>
+++ b/items.c<br>
@@ -434,6 +434,13 @@ item *do_item_get_notedeleted(const char *key, const size_t nkey, bool *delete_l<br>
it = NULL;<br>
}<br>
<br>
+ if (it != NULL && settings.soft_timeout > 0 && it->exptime != 0 &&<br>
+ (it->exptime - current_time) <= settings.soft_timeout) {<br>
+ if (rand() % settings.soft_timeout >= (it->exptime - current_time)) {<br>
+ it = NULL;<br>
+ }<br>
+ }<br>
+<br>
if (it != NULL) {<br>
it->refcount++;<br>
DEBUG_REFCNT(it, '+');<br>
diff --git a/memcached.c b/memcached.c<br>
index 27456be..6efb47d 100644<br>
--- a/memcached.c<br>
+++ b/memcached.c<br>
@@ -177,6 +177,7 @@ static void settings_init(void) {<br>
settings.managed = false;<br>
settings.factor = 1.25;<br>
settings.chunk_size = 48; /* space for a modest key and value */<br>
+ settings.soft_timeout = 0; /* number of seconds before hard timeout the soft timeout will start */<br>
#ifdef USE_THREADS<br>
settings.num_threads = 4;<br>
#else<br>
@@ -1065,6 +1066,7 @@ static void process_stat(conn *c, token_t *tokens, const size_t ntokens) {<br>
pos += sprintf(pos, "STAT bytes_written %llu\r\n", stats.bytes_written);<br>
pos += sprintf(pos, "STAT limit_maxbytes %llu\r\n", (uint64_t) settings.maxbytes);<br>
pos += sprintf(pos, "STAT threads %u\r\n", settings.num_threads);<br>
+ pos += sprintf(pos, "STAT soft_timeout %d\r\n", settings.soft_timeout);<br>
pos += sprintf(pos, "END");<br>
STATS_UNLOCK();<br>
out_string(c, temp);<br>
@@ -2671,6 +2673,13 @@ static void usage(void) {<br>
"-P <file> save PID in <file>, only used with -d option\n"<br>
"-f <factor> chunk size growth factor, default 1.25\n"<br>
"-n <bytes> minimum space allocated for key+value+flags, default 48\n"<br>
+ "-S <num> Number of seconds before the hard expires to start using\n"<br>
+ " soft expiration. When an item is in soft expiration status,\n"<br>
+ " memcached will tell to SOME clients the item is expired before\n"<br>
+ " its actual expiration. The more the item is close to its actual expiration\n"<br>
+ " time, the more the probability that memcache tell a client the item is\n"<br>
+ " expired. This allow smooth cache refill when a popular key is about to\n"<br>
+ " expire.\n"<br>
<br>
#if defined(HAVE_GETPAGESIZES) && defined(HAVE_MEMCNTL)<br>
"-L Try to use large memory pages (if available). Increasing\n"<br>
@@ -2861,7 +2870,7 @@ int main (int argc, char **argv) {<br>
setbuf(stderr, NULL);<br>
<br>
/* process arguments */<br>
- while ((c = getopt(argc, argv, "a:bp:s:U:m:Mc:khirvdl:u:P:f:s:n:t:D:L")) != -1) {<br>
+ while ((c = getopt(argc, argv, "a:bp:s:U:m:Mc:khirvdl:u:P:f:s:n:t:D:S:L")) != -1) {<br>
switch (c) {<br>
case 'a':<br>
/* access for unix domain socket, as octal mask (like chmod)*/<br>
@@ -2952,6 +2961,9 @@ int main (int argc, char **argv) {<br>
}<br>
break;<br>
#endif<br>
+ case 'S':<br>
+ settings.soft_timeout = atoi(optarg);<br>
+ break;<br>
default:<br>
fprintf(stderr, "Illegal argument \"%c\"\n", c);<br>
return 1;<br>
diff --git a/memcached.h b/memcached.h<br>
index ffbe880..ae11c72 100644<br>
--- a/memcached.h<br>
+++ b/memcached.h<br>
@@ -96,6 +96,7 @@ struct settings {<br>
int num_threads; /* number of libevent threads to run */<br>
char prefix_delimiter; /* character that marks a key prefix (for stats) */<br>
int detail_enabled; /* nonzero if we're collecting detailed stats */<br>
+ int soft_timeout;<br>
};<br>
<br>
extern struct stats stats;<br>
<font color="#888888">--<br>
<a href="http://1.5.4.4" target="_blank">1.5.4.4</a><br>
<br>
</font></blockquote></div><br>
</div></div></blockquote></div><br>