No 400 response

[Brad Fitzpatrick]

It wasn't intentional.  I think just laziness.


On Thu, 21 Feb 2008, Eamon Daly wrote:

> Hey, all. I just noticed that if I send a botched request, I
don't get a 400 response as I'd expect:

    [edaly at db-01 Perlbal]$ telnet localhost 8080
    Trying 127.0.0.1...
    Connected to localhost.
    Escape character is '^]'.
    BOTCHED REQUEST

    Connection closed by foreign host.

I think the bailout is at line 264 of Socket.pm:

    unless (($is_res ? $self->{res_headers} : $self->{req_headers}) =
                Perlbal::HTTPHeaders->new(\$hstr, $is_res)) {
        # bogus headers?  close connection.
        print "  bogus headers\n" if Perlbal::DEBUG >= 3;
        return $self->close("parse_header_failure");
    }

It looks intentional. Any reason why it doesn't return a 400
instead?

____________________________________________________________
Eamon Daly