PHP-OpenID-0.0.8.2 released

Carl Howells chowells at janrain.com
Thu Sep 8 10:56:56 PDT 2005


Christian Stocker wrote:
> Hi
> 
> Another Bug:
> 
> trustroot.php, method isSane(), line 97:
>   if( $cnt > 1) && strlen($host_parts[$cnt-2]) <= 3) {
> 
> Doesn't parse for example
> 
> greg.abstrakt.ch
> 
> correctly (and a lot of other internationally common domains).
> 
> I assume the check is for things like example.co.uk etc.
> 
> I don't know, how to make that more correct (not sure, what it actually
> should reject and what not), but removing "&&
> strlen($host_parts[$cnt-2]) <= 3" helped for the time beeing
> 
> And, shall I report bugs here on this list in the future or just
> directly to dan?
> 
> chregu

That's actually an artifact of being a near-direct port of our python 
package.  We've changed our trust-root handling significantly recently, 
as it was way too strict before.  I don't know if a version of our code 
with those changes is available yet.

Carl


More information about the yadis mailing list