[PATCH] Increasing verbosity on gc operation

[Gavin Carr]

Committed.


On Wed, Apr 08, 2009 at 03:55:52PM +1000, Gavin Carr wrote:
> Similarly, the attached patches make the 'gc' operation more verbose, 
> both to be able to sanity check what is being deleted by the garbage
> collection, and to give better progress indications, since gc takes a
> *long* time on large backups.
> 
> Current output is:
> 
>   $ brackup-target -v server_sftp_home gc 
>   1234 chunks removed from target
> 
> The first patch adds more progress reporting as chunks from 
> individual backups are collated e.g.:
> 
>   $ brackup-target -v server_sftp_home gc 
>   Collating chunks from backup home-1219232761 [1/10]
>   Collating chunks from backup home-1219229032 [2/10]
>   Collating chunks from backup home-1219204913 [3/10]
>   <...>
>   Removing orphaned chunks
>   1234 chunks removed from target
> 
> The second patch adds reporting of the individual chunks to be 
> deleted with -v -v e.g.:
> 
>   $ brackup-target -v -v server_sftp_home gc 
>   Collating chunks from backup home-1219232761 [1/10]
>   Collating chunks from backup home-1219229032 [2/10]
>   Collating chunks from backup home-1219204913 [3/10]
>   <...>
>   Orphaned chunks:
>     00/00/sha1.0000a32a4c279053e1bf6eb3bd44a135d83b9802.chunk
>     01/00/sha1.0100868135a3c1b23ed2eede10a996c60741af32.chunk
>     <...>
>   Removing orphaned chunks
>   1234 chunks removed from target
> 
> 
> Thoughts/comments?
> 
> Cheers,
> Gavin
>