raw is not cloned in XMLElement::clone()

Pedro Melo melo at simplicidade.org
Mon Feb 5 12:49:41 UTC 2007


the raw field is not cloned by XMLElement::clone. Shouldn't it be?

Case in point: hooking PresenceCheck, created presence stanza with  
DJabberd::Presence->available($from) and then used set_raw() to add  
capability child (XEP-0115).

When the fallback runs in DJabberd::Presence::_process_inbound_probe 
(), the clone() will not copy the capabilities.

For now, I've added the a

     $clone->{raw}      = $self->{raw};

to XMLElement::clone(), but I'm not sure if this breaks something. I  
think it doesn't.

Best regards,
Pedro Melo
Blog: http://www.simplicidade.org/notes/
Jabber ID: melo at simplicidade.org
Use Jabber!

More information about the Djabberd mailing list