[patch] increased verbosity setting
Evan Martin
martine@danga.com
Sun, 10 Aug 2003 12:14:14 -0700
On Sunday, August 10, 2003, at 02:59 PM, Anatoly Vorobey wrote:
> On Sun, Aug 10, 2003 at 11:50:46AM -0700, Evan Martin wrote:
>> This patch lets you add multiple -v flags. Now -vv will dump the
>> client commands/responses as they come in.
>
> Does this patch have some debugging printf's mistakenly left in?
>
> + printf("update_event %x %x\n", c->ev_flags, new_flags);
> + printf("event_handler %d\n", fd);
Oops. :) I noticed that just after I sent it, and then sent a new
patch that also included a ChangeLog entry, but I managed to send that
new patch only to myself. (I'm using the OSX mail client and I'm a bit
unfamiliar with it, which is also why these patches are coming out a
bit weird.)
> Also:
>
> - if(settings.verbose)
> + if (settings.verbose > 0)
>
> Why? ;)
Yeah, good point. I had something else in mind when I made the
change...
I guess it'd be most appropriate to do some sort of
enum {
LOG_ERRORS,
LOG_PROTOCOL
};
and then use if (settings.verbose > LOG_ERRORS) instead of that > 0,
but that's probably not worth the effort.