try this one now... :)

Brad Fitzpatrick brad at danga.com
Tue Sep 5 01:45:58 UTC 2006


FreeBSD / Solaris users,

Could you try this one?

   http://danga.com/memcached/dist/experimental/memcached-1.2.x-svn362.tar.gz

It now builds quietly on OS X and passes all tests:

$ prove test
test/00-startup.........ok
test/64bit..............skipped
        all skipped: Skipping 64-bit tests on 32-bit build
test/binary-get.........skipped
        all skipped: Tests not written.
test/bogus-commands.....ok
test/daemonize..........ok
test/delete-window......ok 14/20# waiting 5 seconds for the deleter event...
test/delete-window......ok
test/expirations........ok
test/flags..............ok
test/flush-all..........ok
        2/11 skipped: flush_all is still only second-granularity.  need atomic counter on flush_all.
test/getset.............ok
test/incrdecr...........ok
test/lru................skipped
        all skipped: Tests not written.
test/managed-buckets....skipped
        all skipped: Tests not written.
test/multiversioning....ok
test/slab-reassign......skipped
        all skipped: Tests not written.
test/stats..............skipped
        all skipped: Tests not written.
test/udp................skipped
        all skipped: Tests not written.
test/unixsocket.........skipped
        all skipped: Tests not written.
All tests successful, 8 tests and 2 subtests skipped.
Files=18, Tests=94, 31 wallclock secs (11.30 cusr +  4.08 csys = 15.38 CPU)


So I imagine it was the same issue (below) for FreeBSD, etc.  Let me know.

- Brad


---------- Forwarded message ----------
Date: Tue, 5 Sep 2006 01:41:43 +0000 (UTC)
From: commits at code.sixapart.com
To: memcached-commits at lists.danga.com, cvs-commits at livejournal.com
Subject: [memcached] bradfitz,
     r362: the old unixsocket check didn't work on ...

the old unixsocket check didn't work on OS X or other BSDs or Solaris... making it more explicit.

U   trunk/server/memcached.c


Modified: trunk/server/memcached.c
===================================================================
--- trunk/server/memcached.c	2006-09-05 00:22:48 UTC (rev 361)
+++ trunk/server/memcached.c	2006-09-05 01:41:43 UTC (rev 362)
@@ -1296,7 +1296,7 @@
         /* unix socket mode doesn't need this, so zeroed out.  but why
          * is this done for every command?  presumably for UDP
          * mode.  */
-        if (c->request_addr.sa_family != AF_UNSPEC) {
+        if (!settings.socketpath) {
             c->request_addr_size = sizeof(c->request_addr);
         } else {
             c->request_addr_size = 0;




More information about the memcached mailing list