[PATCH] minor cleanups

Brad Fitzpatrick brad at danga.com
Fri Apr 13 19:16:33 UTC 2007

On Fri, 13 Apr 2007, Rob Sanheim wrote:

> > 1.3-rc1? Any real concerns about keeping the multithreaded stuff out of
> > trunk? Time to tag something. :)
> >
> > -Dormando
> Are there reasons not to switch completely to the multithreaded
> branch?  WIth multi-core processors dominating the market  now, if its
> stable and battle tested why not commit to that?  Or at least try it
> for few release candidates...

Assuming the code is battle tested & stable, the only remaining questions
are around the invasiveness of the code, and long-term maintenance cost,
compared to the advantages.  Debugging and hacking on a single-threaded
app is a breeze compared to debugging buggy locking.

And yes, multi-core is common, but there's another easier answer:  run 'n'
processes per machine, which is what everybody does now.  Yes, it's
currently a manual process, but it could be automated.  That also is some
more work, though.

So I guess it's time to start looking at diffs between trunk and
multithreaded and see if it's small/simple enough to merge.  (and assuming
it's still a compile-time option, to complete disable threading...)

I also want to see the win32 stuff merged into trunk... I forgot where
that process was at.  :(

- Brad

More information about the memcached mailing list