[PATCH] new hook chain for unhandled stanzas

[Brad Fitzpatrick]

All other callbacks are async but this one appears to need to require to run
synchronously or this line will fail:
+ return $self->stream_error("unsupported-stanza-type") unless $class;

At minimum you should document in HookDocs.pm that the provided callback
can't defer running the callback into the future.

Also, document this line:

       sub { },

That's the fallback, if I recall correctly?  How about this instead:

       sub {
          # as last-resort, do nothing.  check below will fail with
unsupported stanza type.
       },

Same code, but easier to read.

Fix those and feel free to commit without another review.  (also update
ChangeLog)

On Mon, Nov 3, 2008 at 11:38 AM, <igotimac at gmail.com> wrote:
>
> Code review tool couldn't parse my last patch, trying again
>
>
> http://codereview.appspot.com/2404
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.danga.com/pipermail/djabberd/attachments/20081103/04da2dd8/attachment.htm