答复: Tag Function

[dormando]

Personally, I've queued it for review.

At a glance I had some issues with it, but I don't want to go spouting
off about it without being able to give thorough feedback.

Anyone else is free to review it as well. Also we kind of want to finish
 the binary tree first. So at least, to me, this patch is _not_
forgotten. It's still in my inbox, but I'm focused elsewhere right now.

-Dormando

André Cruz wrote:
> Hello.
> 
> It looks like the patch was never applied to the main trunk.
> Is it unstable? What work remains to be done?
> 
> Best regards,
> André Cruz
> 
> On 2008/02/13, at 07:40, Robert Q. Liu wrote:
> 
>> Hi,
>> I agree with your opinions!
>> We test the "tag-function" for a long time, and there are two patch 
>> files on the web site (one for memcached, one for module).
>> Can you merge they into the main project, please?
>>  
>> Robert Q. Liu
>>  
>> ------------------------------------------------------------------------
>> *发件人:* Chris Goffinet [mailto:goffinet at yahoo-inc.com] 
>> *发送时间:* 2008年2月13日 11:40
>> *收件人:* Dustin Sallings
>> *抄送:* Robert Q. Liu; <memcached at lists.danga.com 
>> <mailto:memcached at lists.danga.com>>
>> *主题:* Re: Tag Function
>>  
>> Dustin:
>>  
>> Thought the same thing. Was a bit off. At least there is a diff on the 
>> site :)
>>  
>>
>> -- 
>> *Chris Goffinet*
>> MyBlogLog Engineer
>> *Yahoo!*
>> San Francisco, CA
>> United States
>>  
>> On Feb 12, 2008, at 7:34 PM, Dustin Sallings wrote:
>>
>>
>>  
>>   I'm sure we all appreciate the effort, but I don't think it was 
>> necessary to create a formal fork of the project to do so.
>>  
>>   Is there something about your implementation that you feel makes it 
>> unsuitable to be merged into the main project?
>>
>> -- 
>> Dustin Sallings (mobile)
>>
>> On Feb 12, 2008, at 19:15, "Robert Q. Liu" <robertqingliu at gmail.com 
>> <mailto:robertqingliu at gmail.com>> wrote:
>>> Hi, all:
>>>  
>>>     We add "Tag Function" for memcached. Propose is remove several 
>>> keys with the same tag in one operation. We use hash and splay tree, 
>>> make the "tag_add" and "tag_delete" commands very quickly, and save 
>>> memory as much as possible.
>>>  
>>> New memcached command:
>>> tag_add <tag> <key>*
>>> tag_delete <tag>
>>>  
>>>     More detail:
>>>          
>>> <http://code.google.com/p/memcached-tag/>http://code.google.com/p/memcached-tag/
>>>  
>>>     If you find BUGS, please tell us, thanks very much.
>>>  
>>> Have Fun!
>>> Robert Q. Liu
>>>  
>>  
>