Win32 port patches
brad at danga.com
Sun Nov 26 20:35:21 UTC 2006
Looks fine to me. My only question is what header files bring in the
C99(?) uint64_t type, and if that's portable to other unixes.
But I'd go ahead and commit it (to trunk only) and we'll figure that out
On Sun, 26 Nov 2006, Jeremy Kronuz wrote:
> Okay, here are the fixes I've added to the patches; it's verified to compile
> under linux and Visual Studio so, again, that shouldn't be a problem :)
> I've added an enum for the "gross" case and also I've removed some of the
> camelStyle code. I kept the ntservice.* files almost intact as they use the
> "windows" coding style, everything else should be consistent with memcached
> coding style. I gues we can also change the ntservice.* but since it makes
> use of windows calls, we won't get rid of all the CaseStyled functions
> anyway, so I just figured it's better just to keep that "module" that way
> and leave it consistent with the "windows coding style".
> What do you think?
> Again, you can also get the patches from:
> (the icon is also in that zip now, but not attached here)
> "Fools rush in where fools have been before" - Unknown
> Don't just search. Find. Check out the new MSN Search!
More information about the memcached