Win32 port patches

Brad Fitzpatrick brad at danga.com
Sat Nov 25 17:17:44 UTC 2006


Few comments...

On Fri, 24 Nov 2006, Jeremy Kronuz wrote:

> Hello,
> I've created some patches to be applied against the current svn memcached.
> These patches are for adding Win32 support and they are intended as a step
> towards making the port part of the main memcached branch.

> 1) memcached-01-warnings.diff
> Reorganizes some stuff in the code and also adds some castings that are not
> automatic in some platforms (such as incrementing a void pointer and the
> like: "void *a; a++;")

You can download VMWare Player for free, then download a Debian sarge/etch
instance which is like 100 MB or so compressed.  Alternatively, we could
just test it for you, but that might get tedious for both of us.

> 2) memcached-02-functions.diff
> Abstracts some functionality by adding run, stop, pause and continue server
> execution functions to memecached (two of which are not yet implemented)

Avoid thatCaseStyle in that file.  be_consistent().   I'm not religious
about one form or another, but I am religious about consistency.

> 3) memcached-03-win32.diff
> Adds the necessary files and the extra modifications to make memcached
> support Win32

Those case 2..case 9 literals are gross.  Make them an enum or #defined or
something?

- Brad



More information about the memcached mailing list